From: Tim Abbott <tabbott@xxxxxxxxxxx> Date: Wed, 16 Sep 2009 14:03:48 -0400 (EDT) > On Wed, 16 Sep 2009, David Miller wrote: > >> It's hard for me to ACK this because it's not a straight nop >> transformation, which we could at least presume would function >> properly if the macros were implemented correctly. > > Would it help if I were to split the patch into first rearranging the code > to look like the macros and then applying the macros, so that you can see > more easily exactly what is changing? No, it wouldn't :-) The issue is that I can't just say from reading the patch that it will absolutely work. But I'm willing to take the risk and we can revert if testing shows it breaks things, so: Acked-by: David S. Miller <davem@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html