2009/8/4 David Miller <davem@xxxxxxxxxxxxx>: > From: Eldar Abusalimov <eldar.abusalimov@xxxxxxxxx> > Date: Tue, 4 Aug 2009 17:09:42 +0400 > >> 2009/8/4 David Miller <davem@xxxxxxxxxxxxx>: >>> From: Eldar Abusalimov <eldar.abusalimov@xxxxxxxxx> >>> Date: Tue, 4 Aug 2009 17:07:32 +0400 >>> >>>> 2009/8/4 David Miller <davem@xxxxxxxxxxxxx>: >>>>> No, a bad user stack would be if %sp >= PAGE_OFFSET, the user stack >>>>> must be below the lowest kernel address which is PAGE_OFFSET. >>>> >>>> Yes, I agree, but you've just written that >>>> >>>>>>> We want to fall through to line 288 if PAGE_OFFSET > %sp and that's >>>>>>> what we do. >>>> >>>> and line 288 is trap_setup_user_stack_is_bolixed branch. >>> >>> Sorry, logic reversed. >>> >> >> So, is it a bug in etrap.S? > > Seems that way, and it's harmless because the real fault handler will > find that things are actually fine and it all works out, albeit > slowly. > > Feel free to test the obvious fix :) > Ok, thanks. =) -- Best regards, Eldar Sh. Abusalimov -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
