Hi,
Ok, I'll rework the patches. I'm on holiday right now,
but I'll do it after 17.August when I'll come back
to the office. I'll test it for Leon and non-Leon, I had it
working non-Leon also but apparently it broke someway
when working to cleanup the patches. The
_amba_init() undefined reference is the only reference
outside the arch/sparc directory. I'll protect it with a #ifdef LEON
kind of macro. The thing is that it is
the root for the Leon specific drivers that are currently
in drivers/ambapp, a new directory which I have to figure
out how to get into the mainline kernel. So it is kind of a
chicken and egg problem, without the arch/sparc part
drivers/ambapp (that contains amba_init() and uart and ethernet
drivers) will not be permitted, without drivers/ambapp arch/sparc
will not compile. Adding all together to the kernel at once will be too
big. So I thought that first get the Leon part of arch/sparc in
and then figure out how to proceed with drivers/ambapp.
amba_init will scan the AMBA bus and detect the connected
devices. It's quite a bit of code and not really connected to arch/sparc.
-- Greetings Konrad
Quoting David Miller <davem@xxxxxxxxxxxxx>:
From: David Miller <davem@xxxxxxxxxxxxx>
Date: Sun, 02 Aug 2009 19:51:40 -0700 (PDT)
> From: Konrad Eisele <konrad@xxxxxxxxxxx>
> Date: Tue, 23 Jun 2009 11:11:42 +0200
>
>> round 5 had wrong numbering, I'll repost.
>
> I'm applying all of this to sparc-next-2.6 and will push it
> out to kernel.org after some build testing.
Ok, I had to revert all of this.
Are you even build testing what you're posting?
arch/sparc/kernel/built-in.o: In function `leon_node_init':
(.init.text+0x29c4): undefined reference to `_amba_init'
I can guess what happened, while respinning these patches you forgot
to do some "git add" commands and thus the file that contains the
amba_init() code is in your tree but not in any of the commits
and thus not in your patches.
When you fix this up and repost the series, do me another favor, try
to build the kernel successfully after each and every patch. With
LEON enabled, the tree does not build after patch #3 because srmmu.c
doesn't include asm/leon.h yet and thus srmmu_swprobe() isn't declared.
Please walk through this patch set carefully, checking the build for
both LEON and non-LEON every step of the way, and after every commit
run "git status" to make sure there are not stray files not checked
into your tree.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
