Re: [PATCH] sparc: fix tftpboot.img build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 21, 2009 at 19:01, David Miller<davem@xxxxxxxxxxxxx> wrote:
> From: Julian Calaby <julian.calaby@xxxxxxxxx>
> Date: Sun, 21 Jun 2009 18:31:04 +1000
>
>> 3. The (I assume) header is calculated slightly differently. (it uses
>> 8191 for a constant in sparc64 and 4095 in sparc32)
>
> Those constants are essentially "PAGE_SIZE - 1".

Ah, they didn't really fit the 32 / 64 bit difference here, maybe I
can (eventually) pass them in from the Makefile, though I'm going to
have to tell the final tool whether it's 64 bit or not anyway, so
maybe it doesn't matter.

>> I think that the bulk of the changes would fit under the umbrella of
>> "endian fixes", and would really like to get hold of the "endian fixes
>> for cross-compiles" patch from Pete Zaitcev <zaitcev@xxxxxxxxx> (CC'd)
>> which was applied to arch/sparc/boot/piggyback.c (as it was at the
>> time) some time in 2000. The problem is that none of the git trees I
>> can find go back any further back than 2002-02-05.
>
> There is a history tree that goes back further at:
>
>        git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git

It goes back to Feb 2002, that's where I ended up in my search, the
only change to arch/sparc/boot/piggyback.c is the initial import on
that date.

>> This patch would probably apply to the sparc64 version without many
>> changes, and would probably make them almost identical apart from the
>> constant and extra step mentioned above.
>
> Yep.

I've given up and am applying it manually. I'm currently trying to get
the Makefile to work properly.

>> I'd also really like to look at the history of this file before it was
>> renamed to piggyback_32.c, however this doesn't seem to be available
>> in any convenient, readily available form. There have been no
>> significant changes to it apart from Sam's sparc32 / 64 merge work
>> since the limit of the history I can find.
>
> These files haven't been touched seriously in many years.

I can see that =)

I'm wondering a little where Debian and Gentoo (my go-tos for sparc
distros) get their images from, but I guess "if it ain't broke, don't
fix it" applies to code too - I'm a little surprised that these
haven't bitrotted =)

(sorry for the reply condensing)

On Sun, Jun 21, 2009 at 19:56, Sam Ravnborg<sam@xxxxxxxxxxxx> wrote:
>>
>> > I'd also really like to look at the history of this file before it was
>> > renamed to piggyback_32.c, however this doesn't seem to be available
>> > in any convenient, readily available form. There have been no
>> > significant changes to it apart from Sam's sparc32 / 64 merge work
>> > since the limit of the history I can find.
>>
>> These files haven't been touched seriously in many years.
>
> git log --follow arch/sparc/boot/piggyback_32.c is your friend.
> Only patch is removal of CVS keywords.

Exactly.

Thanks for the help!

-- 

Julian Calaby

Email: julian.calaby@xxxxxxxxx
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux