Re: [PATCH 3/7] Introduce the sparc-leon CPU type. Add sparc_leon enum,

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2009 at 20:13, <konrad@xxxxxxxxxxx> wrote:
> From: Konrad Eisele <konrad@xxxxxxxxxxx>
>
>> We have two leon.c (+leon.o), this is confusing.
>> Consider a better naming scheme.
>>
>> leon_mm.c, leon_kernel.c for example.
>
> Changed to leon_m.c and leon_k.c

leon_m.c and leon_k.c are significantly better than the original
names, however the reason that leon_mm.c and leon_kernel.c were
suggested is that one can, at a glance, look at the file name and know
what's going on in the file.

Not that these new names are bad, but if you re-spin these patches
again, you might want to consider changing them.

Thanks,

-- 

Julian Calaby

Email: julian.calaby@xxxxxxxxx
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux