David Miller napisał(a): > From: Krzysztof Helt >krzysztof.h1@xxxxxxxxx> > Date: Mon, 4 May 2009 22:37:46 +0200 > > > Use standard fields fbinfo.fix.smem_start and fbinfo.fix.smem_len > > for physical address and length of framebuffer. > > > > This also fixes output of the 'fbset -i' command - address and length > > of the framebuffer is displayed correctly. > > > > Signed-off-by: Krzysztof Helt >krzysztof.h1@xxxxx> > > I think this is not appropriate. > > The "physical address" of these framebuffers is composed of > two values, the 32-bit physical offset and the "which_io" > value. The full physical I/O address is 36 bits. > > Considering either seperately makes no sense. And adjustments > of one make no sense without consideration of the other. > > I see. However, there is no adjustment to the smem_start outside the driver. It is used only to be displayed by the fbset (which is general and does not understand the IO spaces). Another usage is inside the fb_mmap but only if there is no local fb_mmap function defined by the driver. It is not a case for all sbus drivers. Regards, Krzysztof ---------------------------------------------------------------------- Wygraj wycieczke do Eurodisneylandu! Sprawdz >> http://link.interia.pl/f2153 -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
