Re: Unify module.*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> I think it should be safe to do:
> 
> 		BUG_ON(((unsigned long)location >> (unsigned long)32) !=
> 		       (unsigned long)0);
> 
> As to my best understanding unsigned long
> is 32 bit on sparc32 and 64 bit on sparc64.
> So we should with the above code not get any warnings.
> 
> But I did not really see the point of the BUG_ON in the first place,
> and my limited digging did not turn up when it was added.
> 
> So to be safe I kept the ugly ifdef for now.
> If is easy to spot/remove.

And just tell me and I will respin the patch serie
with this or any other modifications requested.

Just to make sure this was explicitly stated.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux