On Sun, Dec 07, 2008 at 08:19:21PM +0100, Sam Ravnborg wrote: > Hi Robert. > > On Sun, Dec 07, 2008 at 01:29:42PM -0500, Robert Reif wrote: > > Use sparc64 version of prom/printf.c. > > > > The only differences for sparc32 is that prom_printf is no longer > > exported for modules which should be OK. > > cyber200fb uses prom_prinf and can be built as a module. > >From Kconfig: > > config FB_CYBER2000 > tristate "CyberPro 2000/2010/5000 support" > depends on FB && PCI && (BROKEN || !SPARC64) > > So it looks to me we should keep the EXPORT. And a test bult with your patch confirmed this: MODPOST 5 modules ERROR: "prom_printf" [drivers/video/cyber2000fb.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 Please redo your patch with the EXPORT kept. I cannot see that it hurts sparc64 so no need to do it conditionally. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
