From: Sam Ravnborg <sam@xxxxxxxxxxxx> Date: Sat, 6 Dec 2008 09:34:16 +0100 > A lot of sparc code uses local extern definitions of > variabels and local function prototypes. > sparse is good at reporting this. > > I tried to look for the right place to add these but > did not really find it. > For sparc64 we have "entry.h" but that does not look like > a shareable file at all. entry.h is for functions and symbols whose definition exists in assembler code on sparc64. If we wanted to do something similar for sparc32 likely we'd initially move entry.h to entry_64.h and create an entry_32.h > So I'm considering creating a sparc/kernel/kernel.h > for all the local definitions for this directory. ... > $ grep extern *32.c | wc -l > 80 If it's for 32-bit stuff, maybe give the header file a foo_32.h name? But otherwise sounds like a good idea. For these things on the sparc64 side I just added them to the closest appropritate header in asm/*.h, there is a series of commits here and there where I addressed sparse warnings in this way. Probably "gitk arch/sparc64" would allow you to scan them quickly. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
