Re: [PATCH] sparc: beautify kernel/cpu_32.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Fri, 5 Dec 2008 18:44:26 +0100

> Fixed style issues
> Use C99 struct assignments
> Use KERN_DEBUG for printk
> 
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> ---
> 
> Looked for similar files and my eyes started to hurt
> when I looked at this code.
> 
> I looked at how sparc64 does it and I like the list of
> real variants better than the sparc32 version with FPU
> and CPU separated.
> 
> But combining the two is for another day.
> 
> If we fail to find the CPU then sparc_cpu_type is unitialized.
> Maybe we should set it to "Unknown CPU" in that case like sparc64 does.
> And if we fail to find the FPU we just pick entry [31] at random..

Applied, thanks Sam.

Ironically I looked at this file yesterday too and also
decided to pass on trying to combine them :)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux