Re: [PATCH] Fix VIS emulation bugs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Joseph S. Myers" <joseph@xxxxxxxxxxxxxxxx>
Date: Thu, 4 Dec 2008 00:41:50 +0000 (UTC)

> This patch fixes some bugs in VIS emulation that cause the GCC test
> failure
> 
> FAIL: gcc.target/sparc/pdist-3.c execution test

Thanks a lot for this fix, I'd been noticing that failure
and had been meaning to look into it.

> for both 32-bit and 64-bit testing on hardware lacking these
> instructions.  The emulation code for the pdist instruction uses
> RS1(insn) for both source registers rs1 and rs2, which is obviously
> wrong and leads to the instruction doing nothing (the observed
> problem), and further inspection of the code shows that RS1 uses a
> shift of 24 and RD a shift of 25, which clearly cannot both be right;
> examining SPARC documentation indicates the correct shift for RS1 is
> 14.
> 
> This patch fixes the bug if single-stepping over the affected
> instruction in the debugger, but not if the testcase is run
> standalone.  For that, Wind River has another patch I hope they will
> send as a followup to this patch submission.
> 
> Signed-off-by: Joseph Myers <joseph@xxxxxxxxxxxxxxxx>

Patch applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux