On Tue, Jun 10, 2008 at 01:01:13PM -0700, David Miller wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Date: Fri, 6 Jun 2008 23:00:13 +0200
>
> > To get rid of ALTARCH in Kbuild copy remaining
> > exported header files that are sparc64 specific to asm-sparc.
> >
> > Copy was done using the following simple script:
> >
> > set -e
> > SPARC64="apb.h bbc.h display7seg.h envctrl.h psrcompat.h pstate.h uctx.h utrap.h watchdog.h"
> > for FILE in ${SPARC64}; do
> > if [ -f asm-sparc/$FILE ]; then
> > echo $FILE exist in asm-sparc
> > fi
> > cat asm-sparc64/$FILE > asm-sparc/$FILE
> > printf "#include <asm-sparc/$FILE>\n" > asm-sparc64/$FILE
> > done
> >
> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Thanks for doing this work Sam.
>
> Looking over this particular patch made me notice that
> asm/apb.h and asm/bbc.h should not be exported to userspace
> at all. And with some searching I verified that no userland
> source bases include these files.
Good catch - this is the problem with these mechancal patches that
they are maybe correct but useless.
>
> They are simply definitions of chip registers and do not
> describe a userland interface of any kind, so this seems
> about right.
>
> psrcompat.h and pstate.h fall roughly into the same category,
> but unfortunately things like strace include these files
> (even though they really don't use the defines) so we have
> to keep exporting them in order to not break userspace.
>
> So what I'm going to do is apply the patch below first to
> sparc-next-2.6, then apply this patch with the apb.h and bbc.h parts
> removed.
Notice that I screwed up the changelog/diff in the last two patches
in the series. I can do a repost when you push your current sparc tree.
But only tomorrow - too late here.
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
