On Wednesday 27 February 2008 09:40:22 pm Benjamin Herrenschmidt wrote: > On Wed, 2008-02-27 at 14:58 -0500, Jarod Wilson wrote: > > On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > > > The generation of incoming requests was filled in in wrong byte order > > > on machines with big endian CPU. > > > > > > Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> > > > Cc: sparclinux@xxxxxxxxxxxxxxx > > > Cc: linuxppc-dev@xxxxxxxxxx > > > --- > > > > > > This patch is a shot in the dark, based on a warning when building with > > > C=1 CHECKFLAGS="-D__CHECK_ENDIAN__". Is it really a fix, or was the > > > previous code accidentally correct? > > > > > > This needs to be tested on different big endian PCs, if possible with > > > the Apple Uninorth FireWire controller and other types of controllers. > > > One test which involves ohci->request_generation is simply with an > > > SBP-2 device (harddisk, CD-ROM...). Does SBP-2 login etc. work? > > > > Works just fine with the Apple UniNorth controller in my powerbook in > > cursory testing. Tested with multiple sbp2 hard disks, plugging and > > unplugging, mounting and unmounting, etc. > > Which specific rev/version of the uninorth controller ? lspci says Apple Computer Inc. UniNorth 2 FireWire (rev 81), pci id 106b:0031, subsys id 106b:5811. (Its a circa 2004 Aluminum 15" PowerBook G4 @ 1.67GHz, fwiw). > There is the "interesting" one has vendorID Apple and deviceID 0x0018, > the normal ones have different deviceIDs (and are just lucent > controllers afaik). Under Mac OS X, system.log says "FireWire (OHCI) Apple ID 31 built-in now active". Could still be lucent though, judging by the subsys device ID of 5811, which matches up w/the Lucent/Agere FW323. But no, apparently I don't have the interesting one. -- Jarod Wilson jwilson@xxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
