On Thu, 17 Jan 2008 11:38:53 -0800 "Pallipadi, Venkatesh" <venkatesh.pallipadi@xxxxxxxxx> wrote: > > > >-----Original Message----- > >From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] > >Sent: Thursday, January 17, 2008 10:56 AM > >To: Mariusz Kozlowski > >Cc: WANG Cong; linux-kernel@xxxxxxxxxxxxxxx; Jeff Dike; > >user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx; David Miller; > >sparclinux@xxxxxxxxxxxxxxx; Ingo Molnar; Thomas Gleixner; > >Pallipadi, Venkatesh > >Subject: Re: [-mm Patch] uml: fix a building error > > > >On Thu, 17 Jan 2008 19:11:13 +0100 Mariusz Kozlowski > ><m.kozlowski@xxxxxxxxxx> wrote: > > > >> Hello, > >> > >> > This patch fixes this building error: > >> > ... > >> > drivers/char/mem.c: In function 'read_mem': > >> > drivers/char/mem.c:136: error: implicit declaration of > >function 'unxlate_dev_mem_ptr' > >> > ... > >> > >> I see this on sparc64 as well: > >> > >> CC drivers/char/mem.o > >> drivers/char/mem.c: In function 'read_mem': > >> drivers/char/mem.c:136: error: implicit declaration of > >function 'unxlate_dev_mem_ptr' > >> make[2]: *** [drivers/char/mem.o] Error 1 > >> make[1]: *** [drivers/char] Error 2 > >> make: *** [drivers] Error 2 > >> > >> Does sparc64 need similar fix? > >> > > > >The PAT patches strike again. > > > >Ingo, I think you might need to toss some cross-compilers into > >that build > >test setup of yours. > > > > These functions were defined for other archs in asm-generic/iomap.h. > We need all archs including it in io.h. I now see only few archs are > including it.. > > Apart from unxlate, there is also ioremap_wc which is defined in the > same way. > > I can send a patch for this. But, I don't have cross compiler setup for > all archs to test. Andrew, I will need your help. Well. - there are a bunch of cross-compiler binaries in http://userweb.kernel.org/~akpm/cross-compilers/ - I'll (again) encourage Ingo to add cross-compilation testing to his auto-testing setup. - I ran out of steam (and the selinux bug crashed my remote cross-compilation test box) so I didn't do much cross-compilation testing on rc8-mm1: just alpha and ia64 iirc. I'd suggest that you just prepare a best-effort patch and when I next get around to doing more cross-compilation any problems shold get weeded out. - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
