* Ingo Molnar (mingo@xxxxxxx) wrote: > > * Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote: > > > > @@ -34,6 +34,7 @@ mctracer_add_trace_entry(struct mctracer > > > { > > > unsigned long idx, idx_next; > > > struct mctracer_entry *entry; > > > + struct task_struct *tsk = current; > > > > Aren't there situations, like in the middle of a context switch, where > > current is not valid ? Is also poses a problem for early boot, and NMI > > tracing. > > no such problems on x86. > > Ingo I based my comments on the following code snippet, but I think I start to understand what makes it "so special" arch/x86/mm/fault_32.c : static inline int vmalloc_fault(unsigned long address) { unsigned long pgd_paddr; pmd_t *pmd_k; pte_t *pte_k; /* * Synchronize this task's top level page-table * with the 'reference' page table. * ----> * Do _not_ use "current" here. We might be inside * an interrupt in the middle of a task switch.. */ pgd_paddr = read_cr3(); pmd_k = vmalloc_sync_one(__va(pgd_paddr), address); if (!pmd_k) return -1; pte_k = pte_offset_kernel(pmd_k, address); if (!pte_present(*pte_k)) return -1; return 0; } At context switch on x86, loading the registers is done first, and only after the is the current pointer set. However, for vmalloc faults, it's the value in the cr3 register that is important, which may not correspond to the cr3 value saved in "current". So, I think using the "pid" and "comm" fields of current, even in NMI context, is not a problem, just as you said. For early boot, the current task will be init_task, which has pid = 0 and comm = "swapper", still ok. Thanks for pointing it out. Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html