Looks good.
Just a few minor things:
On Wed, Jul 25, 2007 at 06:27:46PM +0100, Mark Fortescue wrote:
> Macros have been put in to alow suport for the old static table Cylinder
> Groups
> but this implementation does not use them yet.
But why add them to patch?
> + /* Sort out mod used on SunOS 4.1.3 for fs_state */
> + uspi->s_postblformat = fs32_to_cpu(sb, usb3->fs_postblformat);
> + if (((flags & UFS_ST_MASK) == UFS_ST_SUNOS) &&
> + (uspi->s_postblformat != UFS_42POSTBLFMT))
> + {
> + flags &= ~UFS_ST_MASK;
> + flags |= UFS_ST_SUN;
> + }
> +
>
Documentation/CodingStyle: if () {
> switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
> + case UFS_ST_SUNOS:
> + if (fs32_to_cpu(sb, usb3->fs_postblformat == UFS_42POSTBLFMT))
Really should be so?
May be you mean:
fs32_to_cpu(sb, usb3->fs_postblformat) == UFS_42POSTBLFMT ?
^
--
/Evgeniy
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
