From: David Woodhouse <dwmw2@xxxxxxxxxxxxx> Date: Tue, 03 Jul 2007 15:26:18 -0400 > On Tue, 2007-07-03 at 19:57 +0100, Mark Fortescue wrote: > > > Commit b46b8f19c9cd435ecac4d9d12b39d78c137ecd66 partially fixed alignment > > > issues but does not ensure that all 64bit alignment requirements of sparc32 > > > are met. Tests have shown that the redzone2 word can become misallignd. > > Oops, sorry about that. I'm not sure about your patch though -- I think > I'd prefer to keep the redzone misaligned (and hence _right_ next to the > real data), and just deal with it. > > typedef unsigned long long __aligned__((BYTES_PER_WORD)) redzone_t; Please don't use get_unaligned() or whatever to fix this, it's going to generate the byte-at-a-time accesses on sparc64 which doesn't need it since the redzone will be aligned. - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html