On Mon, Jun 04, 2007 at 11:58:28PM -0700, David Miller wrote: > From: Sam Ravnborg <sam@xxxxxxxxxxxx> > Date: Sat, 2 Jun 2007 22:32:06 +0200 > > > I do not know if it is OK to use .init.text?? > > I would assume that CONFIG_HOTPLUG_CPU had impact here. > > The __INIT and __INITDATA assembler macros in linux/init.h for a while > would select the section properly based upon whether CPU hotplug was > enabled or not, but that got reverted by: > > 838c41184fee5e151c09972f2ba90c16493af614 > > I guess it's much better to put the ugly ifdefs into the assembler > code by someone's estimation :-( That's how the x86 trampoline.S, for > example, is handling this. That change was anyway bogus. There should be a 1:1 between __init and __INIT So the HOTPLUG aware definitions should be named: __DEVINIT, __DEVINITDATA and the HOTPLUG_CPU aware definitions should be named_ __CPUINIT, __CPUINITDATA Will cook up a patch for this. > > The sparc64 trampoline.S should definitely use .init.foo when > CPU hotplug is enabled. Will include that too. Sam - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
