Re: QuadEthernet driver broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

The MAC address assignment at module loading is simply forgotten.
The bug at module unloading is caused by an incorrect call.

The bug at module unloading does not only happen for sunqe,
sunlance and sunhme (sbus) suffer from it too.

This patch fixes the sunqe driver.
The sunlance and sunhme will follow.

I've tested this on my SS20.
Thanks.

Signed-off-by: Marcel van Nies <morcles@xxxxxxxxx>

--- linux-2.6.21-rc7-git5-up/drivers/net/sunqe.c.org	2007-02-04
19:44:54.000000000 +0100
+++ linux-2.6.21-rc7-git5-up/drivers/net/sunqe.c	2007-04-21
20:15:08.000000000 +0200
@@ -845,6 +845,8 @@
	if (!dev)
		return -ENOMEM;

+	memcpy(dev->dev_addr, idprom->id_ethaddr, 6);
+
	qe = netdev_priv(dev);

	i = of_getintprop_default(sdev->ofdev.node, "channel#", -1);
@@ -960,7 +962,7 @@
	struct sunqe *qp = dev_get_drvdata(&dev->dev);
	struct net_device *net_dev = qp->dev;

-	unregister_netdevice(net_dev);
+	unregister_netdev(net_dev);

	sbus_iounmap(qp->qcregs, CREG_REG_SIZE);
	sbus_iounmap(qp->mregs, MREGS_REG_SIZE);
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux