Re: [PATCH] sparc32: fix gcc over-optimizatoin near ip_fast_csum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Bob Breuer <breuerr@xxxxxx>
Date: Sun, 14 Jan 2007 14:32:57 -0600

> Fix over-optimization by GCC near ip_fast_csum.
> 
> In some cases such as:
> 	iph->check = 0;
> 	iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
> GCC may optimize out the previous store.
> 
> Observed as a failure of NFS over udp (bad checksums on ip fragments) when 
> compiled with GCC 3.4.2.
> 
> Signed-off-by: Bob Breuer <breuerr@xxxxxx>

Thanks for finding this bug, patch applied.

This issue may be why I made ip_fast_csum() non-inlined on
sparc64 :-)
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux