Re: [PATCH] sparc64: isa.c should cope with OBP nodes with no "reg" property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: richm@xxxxxxxxxxxxxxx
Date: Sat, 23 Dec 2006 23:07:25 +0000

> From: Richard Mortimer <richm@xxxxxxxxxxxxxxx>
> 
> The todm5819 Openboot device node on Netra X1 does not have a "reg"
> property. In this case of_get_property returns NULL resulting in an
> Oops. Avoid this by returning from isa_dev_get_resource() without
> attempting to request_resource().
> 
> Signed-off-by: Richard Mortimer <richm@xxxxxxxxxxxxxxx>

Thanks for catching this.

It's really aweful how we return the "pregs" here but it's
ultimately unused, because even though we end up passing it
to isa_dev_get_irq() that function doesn't even use the pregs
argument.

So let's just return void from isa_dev_get_resource() and drop
the pregs arg from isa_dev_get_irq().

I'll apply the following as ths fix, thanks again.

-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux