Re: [PATCH 1/4] fix sparc32 modpost warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 10, 2006 at 02:21:21PM -0700, David Miller wrote:
> From: Martin Habets <errandir_news@xxxxxxxxxxxxxxxxx>
> Date: Tue, 10 Oct 2006 16:44:16 +0100
> 
> > Subject: [PATCH 1/4] fix sparc32 modpost warnings
> > 
> > Fix these 2.6.19-rc1 build warnings from modpost:
> > 
> > WARNING: vmlinux - Section mismatch: reference to .init.text:_sinittext from .text between 'core_kernel_text' (at offset 0x3e060) and '__kernel_text_address'
>  ...
> > @@ -36,11 +36,11 @@
> >  
> >    . = ALIGN(4096);
> >    __init_begin = .;
> > +  _sinittext = .;
> >    .init.text : { 
> > -	_sinittext = .;
> >  	*(.init.text)
> > -	_einittext = .;
> >    }
> > +  _einittext = .;
> >    __init_text_end = .;
> >    .init.data : { *(.init.data) }
> >    . = ALIGN(16);
> 
> This doesn't make any sense.  No other architecture specifies
> the init sections in this way in their vmlinux.lds.S file.

The frv is the only architecture that has it this way.
I just build 2.6.19-rc1 for i386, expecting to see the same build warning.
It did not appear, which puzzles me at the moment. Do you get this
warning for sparc64?

> Why is this change correct?

The symbols are used from functions that realy should be .text (like
core_kernel_text() in kernel/extable.c). They are not referenced from
anything in an .init.text sections. So moving them seemed like the right
solution.

> Can you try to track down the real problem that causes this
> and then explain it clearly in the patch that you end up
> posting?

My guess is all architectures except sparc and frv have some code to
prevent the warning. I'll see what I can find.

Thanks,
-- 
Martin
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux