From: Willy Tarreau <w@xxxxxx> Date: Tue, 19 Sep 2006 20:26:38 +0200 > On Sun, Sep 17, 2006 at 10:35:12PM -0700, David Miller wrote: > > From: "Jurzitza, Dieter" <DJurzitza@xxxxxxxxxxxxxxxx> > > Date: Mon, 18 Sep 2006 07:23:58 +0200 > > > > > The 2.4 kernel series uses sys32_get_kernel_syms(struct kernel_sym32 > > > *table) for reading the kernel symbols (on sparc64). The size of > > > struct kernel_sym is 64 byte on "normal" arches, but 72 byte on > > > sparc64. > > > > Jurzita, you do not need to post this patch multiple times. > > I was simply on vacation for 2 weeks right after your first > > posting so I had no chance to review the patch. > > BTW, did you finally review it (no emergency at all on my side) ? There are two problems: 1) If this goes in, similar fixes for sys_ia32.c, mips64, et al. should go in at the same time. 2) I dislike this fix because it means that users can lock down a significant amount of non-swappable kernel memory. There are no privilege checks in the get_kernel_syms() system call, so anyone can invoke it. Imagine a fork bomb invoking this, and it could also potentially eat up nearly all of the vmalloc() space. It may be, in the end, simply better to have a "compat_sys_get_kernel_syms" written that can be called so a temporary kernel copy is not needed. I'm not offering to implement this :-) But it does seem to be the only reasonable solution. - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
