WG: [PATCH] sun disk label: fix signed int usage for sector count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear listmembers,
this is the very same issue as before. Therefore I forward this email to sparclinux, too.
Take care



Dieter Jurzitza


-- 
________________________________________________

HARMAN BECKER AUTOMOTIVE SYSTEMS

Dr.-Ing. Dieter Jurzitza
Manager Hardware Systems
   System Development

Industriegebiet Ittersbach
Becker-Göring Str. 16
D-76307 Karlsbad / Germany

Phone: +49 (0)7248 71-1577
Fax:   +49 (0)7248 71-1216
eMail: DJurzitza@xxxxxxxxxxxxxxxx
Internet: http://www.becker.de
 

> -----Ursprüngliche Nachricht-----
> Von: linux-kernel-owner@xxxxxxxxxxxxxxx 
> [mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] Im Auftrag von 
> Jurzitza, Dieter
> Gesendet: Dienstag, 29. August 2006 06:58
> An: linux-kernel@xxxxxxxxxxxxxxx
> Betreff: AW: [PATCH] sun disk label: fix signed int usage for 
> sector count
> 
> 
> Dear listmembers,
> referring to my own question (and to Jeff Mahoneys email), 
> would it be sufficient to simply change
> 
> - --- linux-2.6.17/fs/partitions/sun.c	2006-01-02 
> 22:21:10.000000000 -0500
> +++ linux-2.6.17.fix/fs/partitions/sun.c	2006-08-26 
> 11:54:54.000000000 -0400
> @@ -74,10 +74,10 @@ int sun_partition(struct parsed_partitio
>  	spc = be16_to_cpu(label->ntrks) * be16_to_cpu(label->nsect);
>  	for (i = 0; i < 8; i++, p++) {
>  		unsigned long st_sector;
> - -		int num_sectors;
> +		unsigned int num_sectors;
>  
>  		st_sector = be32_to_cpu(p->start_cylinder) * spc;
>  		num_sectors = be32_to_cpu(p->num_sectors);
> 
> in order to get rid of the meaningless negative numbers? If 
> possible this would be highly preferrable over a solution 
> that renders this partition useless. If Sun Os cannot handle 
> this, maybe an error message when configuring such a disk 
> would be helpful.
> 
> Once again, thank you for your feedback,
> best regards
> 
> 
> 
> 
> Dieter Jurzitza


*******************************************
Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtuemlich erhalten haben, informieren Sie bitte sofort den Absender und loeschen Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
 
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the contents in this e-mail is strictly forbidden.
*******************************************

-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux