[PATCH] sparc: fix warning on prom_getproperty in openprom.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch resolves the following build warnings seen in 2.6.17-rc3:
drivers/sbus/char/openprom.c:395: warning: ignoring return value of `prom_getproperty', declared with attribute warn_unused_result

Please apply.
Martin

	Signed-off-by: Martin Habets <errandir_news@xxxxxxxxxxxxxxxxx>
---

--- 2.6.17-rc3/drivers/sbus/char/openprom.c.orig	2006-05-06 18:48:44.000000000 +0100
+++ 2.6.17-rc3/drivers/sbus/char/openprom.c	2006-05-06 18:59:40.000000000 +0100
@@ -392,12 +392,13 @@
 			return -ENOMEM;
 		}
 
-		prom_getproperty(op.op_nodeid, str, tmp, len);
+		error = prom_getproperty(op.op_nodeid, str, tmp, len);
 
 		tmp[len] = '\0';
 
-		if (__copy_to_user(argp, &op, sizeof(op)) != 0
-		    || copy_to_user(op.op_buf, tmp, len) != 0)
+		if ((error <= 0) ||
+		    __copy_to_user(argp, &op, sizeof(op)) != 0 ||
+		    copy_to_user(op.op_buf, tmp, len) != 0)
 			error = -EFAULT;
 
 		kfree(tmp);
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux