Hello SoX_NG, you wrote: > `echos` is a bizarre effect that has never worked due to a > bug that overwrote the input samples before using them). Agreed. > It's been "fixed" in sox_ng to do what it says in the > manual and comments but > > 1) It's odd, not a classic effect and seems more like a > coding enthusiasm than a useful effect > > 2) It is exactly the same as "echo" with different (and > more) parameters > > I'm thinking of removing it as useless and distracting > baggage. Well, first of all thanks for your effort fixing it! Nevertheless I think this is too extreme to just throw it out. We had some discussion in issue 276 (https://codeberg.org/sox_ng/sox_ng/issues/276) what a good sequential delay could be. So my preference would be to set up some sequential delay where not all stages are fed with the same input signal, but instead with some sum of previous stages... > There are other reasons to start thinking of a major > release 15.0.0; nothing startling but a few > non-backward-compatible changes are beckoning like making > `silence` trim from the silence point instead of 0.02 > seconds after it, Which is wrong by any reasonable considerations ... > not something we can put in 14.X because at least one > artist has already used this discrepancy to achieve the > result they wanted. Hmm, I cannot see the use case for that behaviour. Maybe some playing around with the thresholds and the durations could take care of that? > `chorus` has also never worked and has been fixed. Twice. > See the waveform images in comment > > https://codeberg.org/sox_ng/sox_ng/issues/276#issuecomment-2581801 > but it is not a chorus, which is the addition of delayed > and detuned version of the same signal; it is a simple > flanger, Now you've lost me. When you are modulating a delay line, you will get a vibrato on the original signal with some slight delay. The current fixed chorus does exactly that with as many parallel stages as you like - at least 7 😉 - (each constituting a parallel "voice"). In contrast, Rob Sykes' flanger only has a single modulated delay line with a feedback loop, so as a flanger it's similar to a chorus, but you will have to play around to recreate a chorus by several flangers and with no feedback applied. > of which we already have a much better one by Rob > Sykes, which can probably be parameterized to do the same > as `chorus`, What we were talking about in another thread is the similarity of phaser and flanger. The current "phaser" uses a single modulated delay line and this is by definition a "flanger". A real phaser consists of a number of allpass-filter stages that do a frequency dependent phase shift. The phaser effect is similar to a flanger, but the comb-filtering is somewhat different. So as already mentioned we should leave the chorus, but replace the phaser (or leave it for compatibility reasons as is and add a "fazer" effect as you had proposed). > So, if a major release is looming, we could replace the > flanging `chorus` with a real chorus. For a reference you will find the following paragraph in https://en.wikipedia.org/wiki/Chorus_(audio_effect) The effect is achieved by taking an audio signal and mixing it with one or more delayed copies of itself. The pitch of the added voices is typically modulated by an LFO, which is implemented similarly to a flanger, except with longer delays and without feedback. In my opinion the current chorus is a "real chorus", but I'm happy to be corrected. Best regards, Prof. Spock _______________________________________________ Sox-users mailing list Sox-users@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/sox-users
