On Aug 11 15:25:36, mans@xxxxxxxxx wrote: > Jan Stary <hans@xxxxxxxx> writes: > > > I am confused by the following commit: > > > > commit fc20c26b2500acb6690f03d610d406bffb8944a9 > > Author: Mans Rullgard <mans@xxxxxxxxx> > > Date: Mon Aug 10 21:38:11 2020 +0100 > > > > build: fix symlink selection > > > > The configure test whether to enable the play/rec links is broken, > > and the makefile uses the same condition for both play/rec and soxi. > > Fix both problems. > > > > diff --git a/configure.ac b/configure.ac > > index 9f55b5f8..12af65b0 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -647,13 +647,13 @@ AC_MSG_RESULT($enable_symlinks) > > enable_playrec_symlinks=no > > if test "$enable_symlinks" = "yes"; then > > SYMLINKS=yes > > - if test false \ > > - -o "$enable_alsa" = yes \ > > - -o "$enable_ao" = yes \ > > - -o "$enable_coreaudio" = yes \ > > - -o "$enable_oss" = yes \ > > - -o "$enable_pulseaudio" = yes \ > > - -o "$enable_sndio" = yes \ > > + if test "" \ > > + -o "$using_alsa" = yes \ > > + -o "$using_ao" = yes \ > > + -o "$using_coreaudio" = yes \ > > + -o "$using_oss" = yes \ > > + -o "$using_pulseaudio" = yes \ > > + -o "$using_sndio" = yes \ > > ; then > > PLAYRECLINKS=yes > > enable_playrec_symlinks=yes > > > > How is using alsa/oss/sndio/whatever > > related to creating symlinks (or not)? > > > > Why do we have both SYMLINKS and PLAYRECLINKS? > > Why is this different for play/rec vs soxi (also below)? > > > > Naively, I would assume we want to create symlinks > > for each of play, rec, soxi, or none of them. > > There is no point in creating play/rec symlinks > when no audio devices are supported since they can't work then. The current build system seems to omit sunaudio and waveaudio from the list above, but with the rationale you describe, they should be there too, right? Or is this intended? Anyway, the manpages still get symlinked even if play/rec don't, e.g. when all the drivers ar explicitly disabled. Is that intended? $ cat /tmp/c --with-alsa=no --with-ao=no --with-coreaudio=no --with-oss=no --with-pulseaudio=no --with-sndio=no --with-sunaudio=no --with-waveaudio=no $ env AUTOCONF_VERSION=2.69 AUTOMAKE_VERSION=1.16 \ ./configure `cat /tmp/c` --prefix=$HOME [...] OPTIONAL DEVICE DRIVERS ao (Xiph)..................no alsa (Linux)...............no coreaudio (Mac OS X).......no sndio (OpenBSD)............no oss........................no pulseaudio.................no sunaudio...................no waveaudio (MS-Windows).....no $ env AUTOCONF_VERSION=2.69 AUTOMAKE_VERSION=1.16 make install [...] cd /home/hans/share/man/man1 && rm -f play.1 && ln -s sox.1 play.1 cd /home/hans/share/man/man1 && rm -f rec.1 && ln -s sox.1 rec.1 Jan _______________________________________________ Sox-users mailing list Sox-users@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/sox-users
