On Mon, Jan 14, 2019 at 02:47:36PM +0000, John Levon wrote: > On Mon, Jan 14, 2019 at 05:38:00PM +0300, Dan Carpenter wrote: > > > Try this patch? > > With both applied, smatch now catches the bad code, thanks! > > Time to run it across everything... Very lightly tested, btw. Especially patch 2 might have subtle side effects. Probably good ones. Or maybe no side effects... regards, dan carpenter