Btw, on my system the main cause of false positives with that test is when people mix "if (ret)" and "if (ret < 0)". When I run smatch, I rebuild the database every morning. Every time you rebuild it builds the call tree more and more. So, for most functions, Smatch eventually figures out all the possible returns and it doesn't matter if you check for negatives or non-zero. There are still some functions which Smatch can't figure out, like there is recursion or if we copy the error code from another thread. I manually hack some of the most problematic in smatch_data/db/kernel.return_fixes. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
