On Feb 15, 2016, at 4:16 AM, Dan Carpenter wrote: > On Sat, Feb 13, 2016 at 11:33:04PM -0500, green@xxxxxxxxxxxxxx wrote: >> --- >> >> I was long annoyed by this and so using my lustre tree as benchmark >> here is the difference in output before and after the patch for this file >> for wrong line numbers: >> http://git.whamcloud.com/fs/lustre-release.git/blob/943612ac470a1f916d44f551eee01c3d51fc9546:/lustre/lfsck/lfsck_layout.c >> >> -lustre/lfsck/lfsck_layout.c:2390 lfsck_layout_recreate_lovea() warn: variable dereferenced before check 'handle' (see line 2386) >> -lustre/lfsck/lfsck_layout.c:2415 lfsck_layout_recreate_lovea() warn: variable dereferenced before check 'handle' (see line 2411) >> +lustre/lfsck/lfsck_layout.c:2390 lfsck_layout_recreate_lovea() warn: variable dereferenced before check 'handle' (see line 2242) >> +lustre/lfsck/lfsck_layout.c:2415 lfsck_layout_recreate_lovea() warn: variable dereferenced before check 'handle' (see line 2242) >> >> Granted, this still remains a false positive, but thta would need a more >> involved fix in this particular check module. > > Wait, we discussed this before and looking at it again now, I think the > warning is correct that the NULL check can be safely removed. The warning is correct and we did discuss it before. But the reason we discussed it before is because while the warning is correct, the "see line" mark is incorrect and goes back to the most previous condition instead of back to the actual usage. So the purpose of the patch is to at least print correct line numbers for cross reference purposes. -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
