On Mon, Nov 24, 2014 at 12:29:12PM +0300, Dan Carpenter wrote: > I added the smatch@xxxxxxxxxxxxxxx list to the CC. Thanks, will do next time. > > on my 64-bit debian machine, I use smatch (version from git as of > > yesterday) to check my accepted patches for i2c. However, since the last > > update, I get lots of false positives about locking: > > > > drivers/i2c/busses/i2c-omap.c:1116 omap_i2c_probe() warn: '0' 0 can't fit into 9223372036854775807 'dev->lock' > > I have written a fix for this. I'll test it and push tomorrow. > > > and sometimes "double unlock" which is also not true. > > > > Can you reproduce this for the above driver? > > I can't reproduce this one with that driver. I have been meaning to > re-write this check for a while. Can you send me another double unlock > warning message? drivers/i2c/busses/i2c-rcar.c:465 rcar_i2c_master_xfer() error: double unlock 'spin_lock:&priv->lock' drivers/i2c/busses/i2c-rcar.c:536 rcar_i2c_probe() warn: '0' 0 can't fit into 9223372036854775807 'priv->lock' I just noticed, that I get these errors only when using an 'allnoconfig' with just I2C enabled. If I use 'multi_v7_defconfig', all is fine.
Attachment:
signature.asc
Description: Digital signature