* Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Mon, Dec 23, 2024 at 1:57 AM Luo Gengkun <luogengkun@xxxxxxxxxxxxxxx> wrote:
> >
> > It seems that the attr parameter was never been used in security
> > checks since it was first introduced by:
> >
> > commit da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
> >
> > so remove it.
> >
> > Signed-off-by: Luo Gengkun <luogengkun@xxxxxxxxxxxxxxx>
> > ---
> > arch/x86/events/intel/bts.c | 2 +-
> > arch/x86/events/intel/core.c | 2 +-
> > arch/x86/events/intel/p4.c | 2 +-
> > drivers/perf/arm_spe_pmu.c | 4 ++--
> > include/linux/lsm_hook_defs.h | 2 +-
> > include/linux/perf_event.h | 10 +++++-----
> > include/linux/security.h | 5 ++---
> > kernel/events/core.c | 14 +++++++-------
> > kernel/trace/trace_event_perf.c | 4 ++--
> > security/security.c | 5 ++---
> > security/selinux/hooks.c | 2 +-
> > 11 files changed, 25 insertions(+), 27 deletions(-)
>
> This patch seems fine to me from a LSM and SELinux perspective, but
> I'd want to see an ACK from the perf folks before I merge this.
A belated:
Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>
Patch still seems to apply fine.
Thanks,
Ingo
