On Wed, Nov 20, 2024 at 6:55 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > On Wed, Nov 20, 2024 at 6:15 PM Thomas Weißschuh > <thomas.weissschuh@xxxxxxxxxxxxx> wrote: > > > > av_permissions.h is not declared as a target and therefore won't be > > added to clean-files automatically by kbuild. > > For details why it is not a target see the Makefile itself. > > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx> > > --- > > security/selinux/Makefile | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/security/selinux/Makefile b/security/selinux/Makefile > > index 86f0575f670da66a9dc57e13a236d6a5551af38e..58129a7c8cfa08f9caf5444f7df776f41056b77a 100644 > > --- a/security/selinux/Makefile > > +++ b/security/selinux/Makefile > > @@ -41,5 +41,8 @@ targets += flask.h > > $(obj)/flask.h: $(obj)/genheaders FORCE > > $(call if_changed,genhdrs) > > > > +# see the note above, remove this line > > +clean-files += av_permissions.h > > + > > hostprogs := genheaders > > HOST_EXTRACFLAGS += -I$(srctree)/security/selinux/include > > Presumably, the attached fixup.diff (comment in 'targets' assignment) > would align with the intention of the maintainer of this Makefile > because you can do > > targets += $(genhdrs) > > without the need of the grouped target feature. > 'make clean' removes files listed in 'targets'. [SIDE NOTE: thank you for the comments/patch, but please don't post patches as attachments, it adds extra steps to review/reply which I find annoying] This approach looks a bit cleaner to me. I thought there was a reason why we only included flask.h in $targets, but I can't remember it well enough to know what it was or even if my memory is correct on this :) > BTW, the NOTE in this Makefile is not true. > https://github.com/torvalds/linux/blob/v6.12/security/selinux/Makefile#L7 > > Even if you use GNU Make 4.3, the grouped target does not work with > the if_changed macro. > > With GNU Make 4.4, it will work as a side-effect of commit > fabb03eac412b5ea19f1a97be31dc8c6fa7fc047 Patches correcting the Makefile comments are welcome, especially if what the comments are suggesting for future revisions is incorrect :) > IMHO, I do not see much benefits for using the group target in this case > because you can still generate flask.h and av_permissions.h > separately. True, although a change in the classmap.h file is going to result in both being generated; generating only one file is going to be very rare and not something a normal developer would see. -- paul-moore.com
