From: Christian Göttsche <cgzones@xxxxxxxxxxxxxx> The variable num_modules is already been dereferenced before the NULL check, and also the code is identical for each condition outcome. Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx> --- libsemanage/src/direct_api.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c index 3b2ab449..b10e5c8f 100644 --- a/libsemanage/src/direct_api.c +++ b/libsemanage/src/direct_api.c @@ -1958,11 +1958,6 @@ static int semanage_direct_list(semanage_handle_t * sh, goto cleanup; } - if (num_modules == 0) { - retval = semanage_direct_get_serial(sh); - goto cleanup; - } - retval = semanage_direct_get_serial(sh); cleanup: -- 2.45.2