Re: [PATCH] checkpolicy/fuzz: fix setjmp condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 21, 2024 at 1:35 PM James Carter <jwcart2@xxxxxxxxx> wrote:
>
> On Fri, Oct 18, 2024 at 11:23 AM Christian Göttsche
> <cgoettsche@xxxxxxxxxxxxx> wrote:
> >
> > From: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> >
> > setjmp(3) returns 0 on the first fake invocation, adjust the condition
> > accordingly.
> >
> > Reported by the OSS Fuzz Introspector[1].
> >
> > [1]: https://storage.googleapis.com/oss-fuzz-introspector/selinux/inspector-report/20241016/fuzz_report.html
> >
> > Fixes: f07fc2a75 ("checkpolicy/fuzz: override YY_FATAL_ERROR")
> > Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
>
> Acked-by: James Carter <jwcart2@xxxxxxxxx>
>

Merged.
Thanks,
Jim

> > ---
> >  checkpolicy/fuzz/checkpolicy-fuzzer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/checkpolicy/fuzz/checkpolicy-fuzzer.c b/checkpolicy/fuzz/checkpolicy-fuzzer.c
> > index ddb43260..331201c0 100644
> > --- a/checkpolicy/fuzz/checkpolicy-fuzzer.c
> > +++ b/checkpolicy/fuzz/checkpolicy-fuzzer.c
> > @@ -101,7 +101,7 @@ static int read_source_policy(policydb_t *p, const uint8_t *data, size_t size)
> >
> >         init_parser(1);
> >
> > -       if (!setjmp(fuzzing_pre_parse_stack_state)) {
> > +       if (setjmp(fuzzing_pre_parse_stack_state) != 0) {
> >                 queue_destroy(id_queue);
> >                 fclose(yyin);
> >                 yylex_destroy();
> > --
> > 2.45.2
> >
> >





[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux