On Wed, May 29, 2024 at 11:27 AM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > Thanks for the additional info in the patch description. I think this > change is fine, although I have a slight preference to simply removing > the dead code rather than commenting it out (a small comment can be > inserted referencing the change if that helps), but ultimately I'll > leave that decision to Ondrej as he has been really driving > maintenance of the selinux-testsuite for the past several years. > However, Ondrej hasn't been responding much on-list lately so it is > possible he is away for a bit; if that is the case I would say to go > ahead with what you have and we can always adjust as needed later. > > Regardless, thanks for spending the time on getting the NFS tests > working. I wonder if this is something we could get working in the GH > Actions CI using NFS over loopback? Yes, that should be trivial - just need to ensure that it installs the additional dependencies identified in the README.md for testing NFS and runs ./tools/nfs.sh, which starts the nfs server, exports to localhost, mounts it, and runs the tests.