Re: [PATCH 2/2 testsuite] tools/nfs.sh: comment out the fscontext= tests for now

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 6, 2024 at 1:51 PM Stephen Smalley
<stephen.smalley.work@xxxxxxxxx> wrote:
>
> These tests currently fail on mount(2) calls due to the directory being
> unlabeled at the point where search access is checked. Until we can resolve
> the underlying issue, comment out these tests to allow the NFS tests to
> be run.

With these two patches, I can run the nfs.sh script to completion with
all tests passing on not only the latest kernel w/ the fix but also
Linux v5.14 with no changes. So it is unclear to me that the tests
being disabled by these two patches ever worked...

>
> Signed-off-by: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
> ---
>  tools/nfs.sh | 40 ++++++++++++++++++++--------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/tools/nfs.sh b/tools/nfs.sh
> index cf4912c..688903e 100755
> --- a/tools/nfs.sh
> +++ b/tools/nfs.sh
> @@ -77,27 +77,27 @@ POPD=0
>  popd >/dev/null 2>&1
>  umount /mnt/selinux-testsuite
>  #
> -echo -e "Run 'filesystem' tests with mount context option:\n\t$FS_CTX"
> -mount -t nfs -o vers=4.2,$FS_CTX localhost:$TESTDIR /mnt/selinux-testsuite
> -pushd /mnt/selinux-testsuite >/dev/null 2>&1
> -POPD=1
> -cd tests
> -./nfsruntests.pl filesystem/test
> -cd ../
> -POPD=0
> -popd >/dev/null 2>&1
> -umount /mnt/selinux-testsuite
> +#echo -e "Run 'filesystem' tests with mount context option:\n\t$FS_CTX"
> +#mount -t nfs -o vers=4.2,$FS_CTX localhost:$TESTDIR /mnt/selinux-testsuite
> +#pushd /mnt/selinux-testsuite >/dev/null 2>&1
> +#POPD=1
> +#cd tests
> +#./nfsruntests.pl filesystem/test
> +#cd ../
> +#POPD=0
> +#popd >/dev/null 2>&1
> +#umount /mnt/selinux-testsuite
>  #
> -echo -e "Run 'fs_filesystem' tests with mount context option:\n\t$FS_CTX"
> -mount -t nfs -o vers=4.2,$FS_CTX localhost:$TESTDIR /mnt/selinux-testsuite
> -pushd /mnt/selinux-testsuite >/dev/null 2>&1
> -POPD=1
> -cd tests
> -./nfsruntests.pl fs_filesystem/test
> -cd ../
> -POPD=0
> -popd >/dev/null 2>&1
> -umount /mnt/selinux-testsuite
> +#echo -e "Run 'fs_filesystem' tests with mount context option:\n\t$FS_CTX"
> +#mount -t nfs -o vers=4.2,$FS_CTX localhost:$TESTDIR /mnt/selinux-testsuite
> +#pushd /mnt/selinux-testsuite >/dev/null 2>&1
> +#POPD=1
> +#cd tests
> +#./nfsruntests.pl fs_filesystem/test
> +#cd ../
> +#POPD=0
> +#popd >/dev/null 2>&1
> +#umount /mnt/selinux-testsuite
>  #
>  echo "Run NFS context specific tests"
>  cd tests
> --
> 2.40.1
>





[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux