On Tue, Apr 2, 2024 at 11:29 AM Christian Göttsche
<cgoettsche@xxxxxxxxxxxxx> wrote:
>
> From: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
>
> Include the necessary header for isprint(3) to avoid an implicit
> function declaration:
>
> policy_scan.l: In function ‘yyerror’:
> policy_scan.l:342:13: warning: implicit declaration of function ‘isprint’ [-Wimplicit-function-declaration]
> 342 | if (isprint((unsigned char)yytext[0])) {
> | ^~~~~~~
> policy_scan.l:36:1: note: include ‘<ctype.h>’ or provide a declaration of ‘isprint’
> 35 | #include "y.tab.h"
> +++ |+#include <ctype.h>
> 36 | #endif
>
> This does not currently break the build cause -Werror is stripped for
> the parsing code to avoid breakage on old flex/bison versions that might
> not generate warning free code.
>
> Fixes: 39b3cc51350a ("checkpolicy: handle unprintable token")
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
For these six patches:
Acked-by: James Carter <jwcart2@xxxxxxxxx>
> ---
> checkpolicy/policy_scan.l | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l
> index d7cf2896..62f28c11 100644
> --- a/checkpolicy/policy_scan.l
> +++ b/checkpolicy/policy_scan.l
> @@ -22,6 +22,7 @@
>
> %{
> #include <sys/types.h>
> +#include <ctype.h>
> #include <limits.h>
> #include <stdint.h>
> #include <string.h>
> --
> 2.43.0
>
>
