Re: [PATCH] security: new security_file_ioctl_compat() hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Paul Moore <paul@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] security: new security_file_ioctl_compat() hook
From: Eric Biggers <ebiggers@xxxxxxxxxx>
Date: Sat, 23 Dec 2023 09:34:11 -0600
Cc: Alfred Piccioni <alpic@xxxxxxxxxx>, Stephen Smalley <stephen.smalley.work@xxxxxxxxx>, Eric Paris <eparis@xxxxxxxxxxxxxx>, linux-security-module@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Casey Schaufler <casey@xxxxxxxxxxxxxxxx>, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <CAHC9VhTpc7SD0t-5AJ49+b-FMTx1svDBQcR7j6c1rmREUNW7gg@mail.gmail.com>
References: <20230906102557.3432236-1-alpic@google.com> <20231219090909.2827497-1-alpic@google.com> <CAHC9VhTpc7SD0t-5AJ49+b-FMTx1svDBQcR7j6c1rmREUNW7gg@mail.gmail.com>

On Fri, Dec 22, 2023 at 08:23:26PM -0500, Paul Moore wrote:
> 
> Is it considered valid for a native 64-bit task to use 32-bit
> FS_IO32_XXX flags?

No, that's not valid.

> If not, do we want to remove the FS_IO32_XXX flag
> checks in selinux_file_ioctl()?

I don't see any such flag checks in selinux_file_ioctl().

Is there something else you have in mind?

- Eric

Follow-Ups:
- Re: [PATCH] security: new security_file_ioctl_compat() hook
  - From: Paul Moore

References:
- [PATCH] SELinux: Check correct permissions for FS_IOC32_*
  - From: Alfred Piccioni
- [PATCH] security: new security_file_ioctl_compat() hook
  - From: Alfred Piccioni
- Re: [PATCH] security: new security_file_ioctl_compat() hook
  - From: Paul Moore

Prev by Date: Re: [PATCH] security: new security_file_ioctl_compat() hook
Next by Date: Re: [PATCH] security: new security_file_ioctl_compat() hook
Previous by thread: Re: [PATCH] security: new security_file_ioctl_compat() hook
Next by thread: Re: [PATCH] security: new security_file_ioctl_compat() hook
Index(es):
- Date
- Thread

[Index of Archives] [Selinux Refpolicy] [Linux SGX] [Fedora Users] [Fedora Desktop] [Yosemite Photos] [Yosemite Camping] [Yosemite Campsites] [KDE Users] [Gnome Users]