On Tue, Nov 14, 2023 at 09:53:41PM +0000, Al Viro wrote: > On Tue, Nov 14, 2023 at 03:57:35PM -0500, Stephen Smalley wrote: > > On Mon, Nov 13, 2023 at 11:19 AM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > > > > > On Mon, Oct 16, 2023 at 6:08 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > [ > > > > That thing sits in viro/vfs.git#work.selinuxfs; I have > > > > lock_rename()-related followups in another branch, so a pull would be more > > > > convenient for me than cherry-pick. NOTE: testing and comments would > > > > be very welcome - as it is, the patch is pretty much untested beyond > > > > "it builds". > > > > ] > > > > > > Hi Al, > > > > > > I will admit to glossing over the comment above when I merged this > > > into the selinux/dev branch last night. As it's been a few weeks, I'm > > > not sure if the comment above still applies, but if it does let me > > > know and I can yank/revert the patch in favor of a larger pull. Let > > > me know what you'd like to do. > > > > Seeing this during testsuite runs: > > Interesting... i_nlink decrement hitting an inode already with zero > nlink... > > <pokes around> > > Could you add > inc_nlink(sb->s_root->d_inode); > in sel_make_swapover_dir() right before > inode_unlock(sb->s_root->d_inode); > > and check if that fixes the problem? See git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #for-selinux
