On Mon, 2023-09-04 at 15:40 +0200, Roberto Sassu wrote: > From: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > Remove hardcoded IMA function calls (not for appraisal) from the LSM > infrastructure, the VFS, NFS and the key subsystem. > > Make those functions as static (except for ima_file_check() which is > exported, and ima_post_key_create_or_update(), which is not in ima_main.c), > and register them as implementation of the respective hooks in the new > function init_ima_lsm(). ima_post_path_mknod() is currently enabled whether or not CONFIG_SECURITY_PATH is enabled. Now it will only be enabled when CONFIG_SECURITY_PATH is confiured. Changes like this need to be mentioned. > Call init_ima_lsm() from integrity_lsm_init() (renamed from > integrity_iintcache_init()), to make sure that the integrity subsystem is > ready at the time IMA hooks are registered. The same will be done for EVM, > by calling init_evm_lsm() just after init_ima_lsm(). Instead of creating separate IMA and EVM LSMs, the hooks are being added to "integrity". Some sort of (brief) explanation should be provided. security_add_hooks(ima_hooks, ARRAY_SIZE(ima_hooks), "integrity"); > > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > Acked-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > Reviewed-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx> -- thanks, Mimi