Re: [RFC PATCH v2 23/27] libselinux: free elements on read_spec_entries() failure

[James Carter <jwcart2@xxxxxxxxx>]

On Mon, Aug 14, 2023 at 9:42 AM Christian Göttsche
<cgzones@xxxxxxxxxxxxxx> wrote:
>
> Some entries might have been already parsed and allocated.
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>

Acked-by: James Carter <jwcart2@xxxxxxxxx>

> ---
> v2: add patch
> ---
>  libselinux/src/label_file.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libselinux/src/label_file.h b/libselinux/src/label_file.h
> index 56439e2d..3827b5c0 100644
> --- a/libselinux/src/label_file.h
> +++ b/libselinux/src/label_file.h
> @@ -446,6 +446,9 @@ static inline int process_line(struct selabel_handle *rec,
>                                     "%s:  line %u error due to: %m\n", path,
>                                     lineno);
>                 }
> +               free(regex);
> +               free(type);
> +               free(context);
>                 return -1;
>         }
>
> --
> 2.40.1
>