On Thu, Aug 24, 2023 at 9:04 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Khadija, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > [also build test ERROR on pcmoore-selinux/next pcmoore-audit/next linus/master v6.5-rc7 next-20230824] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Khadija-Kamran/lsm-constify-the-mm-parameter-in-security_vm_enough_memory_mm/20230823-145455 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/ZOWtBTKkfcc8sKkY%40gmail.com > patch subject: [PATCH] lsm: constify the 'mm' parameter in security_vm_enough_memory_mm() > config: arc-randconfig-001-20230824 (https://download.01.org/0day-ci/archive/20230824/202308242024.q4KF0YIN-lkp@xxxxxxxxx/config) > compiler: arc-elf-gcc (GCC) 13.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20230824/202308242024.q4KF0YIN-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202308242024.q4KF0YIN-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > >> mm/util.c:928:5: error: conflicting types for '__vm_enough_memory'; have 'int(struct mm_struct *, long int, int)' > 928 | int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > | ^~~~~~~~~~~~~~~~~~ > In file included from mm/util.c:2: > include/linux/mm.h:3199:12: note: previous declaration of '__vm_enough_memory' with type 'int(const struct mm_struct *, long int, int)' > 3199 | extern int __vm_enough_memory(const struct mm_struct *mm, long pages, int cap_sys_admin); > | ^~~~~~~~~~~~~~~~~~ It looks like you will also need to update the __vm_enough_memory() definition to take a const mm_struct parameter. I looked quickly at the function just now and I don't think that will be a problem. -- paul-moore.com
