Re: [PATCH] libsemanage/tests: use strict prototypes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 9, 2023 at 10:18 AM James Carter <jwcart2@xxxxxxxxx> wrote:
>
> On Sat, Aug 5, 2023 at 6:18 AM Christian Göttsche
> <cgzones@xxxxxxxxxxxxxx> wrote:
> >
> >     utilities.c:39:22: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> >     int create_test_store() {
> >                          ^
> >                           void
> >     utilities.c:171:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> >     int destroy_test_store() {
> >                           ^
> >                            void
> >
> > Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
>
> Acked-by: James Carter <jwcart2@xxxxxxxxx>
>

Merged.
Thanks,
Jim

> > ---
> >  libsemanage/tests/utilities.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libsemanage/tests/utilities.c b/libsemanage/tests/utilities.c
> > index 71d7af1e..806869e0 100644
> > --- a/libsemanage/tests/utilities.c
> > +++ b/libsemanage/tests/utilities.c
> > @@ -36,7 +36,7 @@ void test_msg_handler(void *varg, semanage_handle_t *handle, const char *fmt,
> >  {
> >  }
> >
> > -int create_test_store() {
> > +int create_test_store(void) {
> >         FILE *fptr;
> >
> >         if (mkdir("test-policy", 0700) < 0)
> > @@ -168,7 +168,7 @@ int write_test_policy_src(unsigned char *data, unsigned int data_len) {
> >         return 0;
> >  }
> >
> > -int destroy_test_store() {
> > +int destroy_test_store(void) {
> >         FTS *ftsp = NULL;
> >         FTSENT *curr = NULL;
> >         int ret = 0;
> > --
> > 2.40.1
> >




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux