Petr Lautrbach <plautrba@xxxxxxxxxx> writes: > James Carter <jwcart2@xxxxxxxxx> writes: > >> CI testing fails while running flake8 on python scripts with the >> message "./python/semanage/seobject.py:250:16: E721 do not compare >> types, for exact checks use `is` / `is not`, for instance checks use >> `isinstance()`" >> >> Use "isinstance(args, str)" instead of "type(args) == str" >> >> Signed-off-by: James Carter <jwcart2@xxxxxxxxx> > > Acked-by: Petr Lautrbach <lautrbach@xxxxxxxxxx> This is merged now, thanks! > >> --- >> python/semanage/seobject.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/python/semanage/seobject.py b/python/semanage/seobject.py >> index 361205d1..cc944ae2 100644 >> --- a/python/semanage/seobject.py >> +++ b/python/semanage/seobject.py >> @@ -247,7 +247,7 @@ class semanageRecords: >> global handle >> if args: >> # legacy code - args was store originally >> - if type(args) == str: >> + if isinstance(args, str): >> self.store = args >> else: >> self.args = args >> -- >> 2.41.0
