On Jul 28, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@xxxxxxxxxxxxxx> wrote:
>
> Use umode_t as parameter type for sel_make_inode(), which assigns the
> value to the member i_mode of struct inode.
>
> Use identical type for loop iterator.
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> ---
> v2: avoid declarations in init-clauses of for loops
> ---
> security/selinux/selinuxfs.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index b969e87fd870..7d7931d1758e 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
...
> @@ -1623,7 +1622,7 @@ static int sel_make_avc_files(struct dentry *dir)
> #endif
> };
>
> - for (i = 0; i < ARRAY_SIZE(files); i++) {
> + for (u32 i = 0; i < ARRAY_SIZE(files); i++) {
No initializers in the for-loop ;)
Also, how did you decide 'i' should be a u32?
> struct inode *inode;
> struct dentry *dentry;
>
> @@ -1649,7 +1648,7 @@ static int sel_make_ss_files(struct dentry *dir)
> {
> struct super_block *sb = dir->d_sb;
> struct selinux_fs_info *fsi = sb->s_fs_info;
> - int i;
> + u32 i;
Same as above, why u32?
> static const struct tree_descr files[] = {
> { "sidtab_hash_stats", &sel_sidtab_hash_stats_ops, S_IRUGO },
> };
> @@ -1700,7 +1699,7 @@ static const struct file_operations sel_initcon_ops = {
>
> static int sel_make_initcon_files(struct dentry *dir)
> {
> - int i;
> + u32 i;
Again, why u32?
> for (i = 1; i <= SECINITSID_NUM; i++) {
> struct inode *inode;
> --
> 2.40.1
--
paul-moore.com
