Re: [PATCH] selinux: more Makefile tweaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 6, 2023 at 12:50 AM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
>
> A few small tweaks to improve the SELinux Makefile:
>
> - Define a new variable, 'genhdrs', to represent both flask.h and
>   av_permissions.h; this should help ensure consistent processing for
>   both generated headers.
>
> - Move the 'ccflags-y' variable closer to the top, just after the
>   main 'obj-$(CONFIG_SECURITY_SELINUX)' definition to make it more
>   visible and improve the grouping in the Makefile.
>
> - Rework some of the vertical whitespace to improve some of the
>   grouping in the Makefile.
>
> Signed-off-by: Paul Moore <paul@xxxxxxxxxxxxxx>
> ---
>  security/selinux/Makefile | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)

LGTM,

Reviewed-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>

-- 
Ondrej Mosnacek
Senior Software Engineer, Linux Security - SELinux kernel
Red Hat, Inc.





[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux