Re: [PATCH 1/3] libselinux: drop obsolete optimization flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 01, 2023 at 11:55:08AM +0100, Christian Göttsche wrote:
> The optimization flag -funit-at-a-time is enabled by default in GCC[1]
> and not supported by Clang:
> 
>     clang: error: optimization flag '-funit-at-a-time' is not supported [-Werror,-Wignored-optimization-argument]
> 
> [1]: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
> 
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
This whole series:
Acked-by: Jason Zaman <jason@xxxxxxxxxxxxx>
And merged, thanks!
> ---
>  libselinux/src/Makefile   | 2 +-
>  libselinux/utils/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> index 70ba063a..36d57122 100644
> --- a/libselinux/src/Makefile
> +++ b/libselinux/src/Makefile
> @@ -86,7 +86,7 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi
>            -Wno-missing-field-initializers -Wno-sign-compare \
>            -Wno-format-nonliteral -Wframe-larger-than=$(MAX_STACK_SIZE) \
>            -fstack-protector-all --param=ssp-buffer-size=4 -fexceptions \
> -          -fasynchronous-unwind-tables -fdiagnostics-show-option -funit-at-a-time \
> +          -fasynchronous-unwind-tables -fdiagnostics-show-option \
>            -Werror -Wno-aggregate-return -Wno-redundant-decls \
>            $(EXTRA_CFLAGS)
>  
> diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile
> index 801066cb..f3cedc11 100644
> --- a/libselinux/utils/Makefile
> +++ b/libselinux/utils/Makefile
> @@ -32,7 +32,7 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi
>            -Wno-missing-field-initializers -Wno-sign-compare \
>            -Wno-format-nonliteral -Wframe-larger-than=$(MAX_STACK_SIZE) -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 \
>            -fstack-protector-all --param=ssp-buffer-size=4 -fexceptions \
> -          -fasynchronous-unwind-tables -fdiagnostics-show-option -funit-at-a-time \
> +          -fasynchronous-unwind-tables -fdiagnostics-show-option \
>            -Werror -Wno-aggregate-return -Wno-redundant-decls -Wstrict-overflow=5 \
>            $(EXTRA_CFLAGS)
>  
> -- 
> 2.39.1
> 



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux