On Mon, Jan 9, 2023 at 10:18 PM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
> The extra zero byte at the beginning is unnecessary and not expected by
> the kernel. While the generic DH implementation is able to deal with it,
> at least one hardware driver implementation (intel_qat) rejects it.
> Since the kernel's test vectors do not include one with zero bytes at
> the beginning, assume that it's invalid and remove it from our prime
> byte array.
>
> While there also regroup the byte values by 8 instead of 10, so that it
> is easy to verify that the size of the array is a multiple of 8 as
> expected.
>
> Verified on a machine with the Intel QAT accelerator, where the test was
> failing before.
>
> Fixes: 85832b99b430 ("tests/keys: use a longer prime in DH params")
> Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
Applied:
https://github.com/SELinuxProject/selinux-testsuite/commit/5dda1f3f2dc2274a13e423dcb20292129b6633d5
--
Ondrej Mosnacek
Senior Software Engineer, Linux Security - SELinux kernel
Red Hat, Inc.
