On Wed, Dec 21, 2022 at 10:44:51PM -0800, Jason Zaman wrote: > When the python bindings are installed to a destdir with pip install > --prefix= --root=, pip tries to uninstall the existing root-owned > package and fails > > Fixes: > running build_ext > python3 -m pip install --prefix=/usr `test -n "/tmp/selinux-release//build-master" && echo --root /tmp/selinux-release//build-master` . > Processing /tmp/selinux-release/selinux-master/libselinux/src > Preparing metadata (setup.py) ... done > Building wheels for collected packages: selinux > Building wheel for selinux (setup.py) ... done > Created wheel for selinux: filename=selinux-3.4-cp310-cp310-linux_x86_64.whl size=725511 sha256=b35e9cdb2a6efce389eeece45446826b4ac6b41f81fdc128893f947036f27e8e > Stored in directory: /tmp/pip-ephem-wheel-cache-kemjh99e/wheels/ca/2d/1e/d1ab52426d9add92931471cfa0d2558bcbeed89084af2388c9 > Successfully built selinux > Installing collected packages: selinux > Attempting uninstall: selinux > Found existing installation: selinux 3.4 > Uninstalling selinux-3.4: > ERROR: Could not install packages due to an OSError: [Errno 13] Permission denied: '__init__.cpython-310.pyc' > Consider using the `--user` option or check the permissions. > --- > libselinux/src/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile > index 0f6396ab..70ba063a 100644 > --- a/libselinux/src/Makefile > +++ b/libselinux/src/Makefile > @@ -187,7 +187,7 @@ install: all > ln -sf --relative $(DESTDIR)$(SHLIBDIR)/$(LIBSO) $(DESTDIR)$(LIBDIR)/$(TARGET) > > install-pywrap: pywrap > - $(PYTHON) -m pip install --prefix=$(PREFIX) `test -n "$(DESTDIR)" && echo --root $(DESTDIR)` $(PYTHON_SETUP_ARGS) . > + $(PYTHON) -m pip install --prefix=$(PREFIX) `test -n "$(DESTDIR)" && echo --root $(DESTDIR) --ignore-installed --no-deps` $(PYTHON_SETUP_ARGS) . > install -m 644 $(SWIGPYOUT) $(DESTDIR)$(PYTHONLIBDIR)/selinux/__init__.py I ran into this when preparing the 3.5-rc1 release and testing a full rebuild. I also forgot to add my signed-off-by. If someone Ack's this, then I will update with the ack+SoB and push this when I do the release. :) Wkr, Jason
